Changelog from 1 oct 2014
Remove Debug and Clean the Script up, CI Items are now working again
Should fix Item Owner for CI Items
Some more debug, I do see we are now call it on player login but where still not doing anything with the item as the OwnerGUID is coming back empty
More debug Messages
Let add Debug to the Item Disguise System and See if the getCounter Will work better then GetRaw
fix custom items
Fix LevelUp Interval
Remove Debug Messages
fix the Update Timer Finally
Add More Debug Messages
Fix Error 17254
Fix mistake in timers
Fix Zone Change Timer and Add some debug to make sure this is working as it should
Remove unused DB Query's
Fix Crash And Correct Online Checker
Fix Typo
Fix Hour loading to Take out any Time that out of range of 0-23 And Another go at fixing the Hour Check foe who should be online at this time
Some Debug Messages
And Another typo Fix
Fix Typo
Core/FPLayer: Added Store to Load Players to To prevent Querying the DB Every time, Fix Zone Changes to Make sure where moving into correct zones and allowed zones, Added the Who Handler to be able to Filter the List by name,Zone,Area/Level etc..
Core/Items: ItemDisguise Add ObjectGUID to uint64 Conversions should fix item issues
Fix Cross Realm Chat
fix Core Freeze issues
see if this fixers the core freezes
Archive Applied NE Sql Files
Fix SQL Update Files
More debug Output and Fix Default Con-fig Var
More Debug Output
Fix Authenticate logins And add some Output Message for Auth Login for Trinity and NE Version so we can see if there an Conflicting login sue to the two system
More Merge Errors
Fix Conversion from std::string to Char*
More Merge Errors And Add MAKE_NEW_GUID Back tot he core For Use with the ChatServer
Fix Merge Error In GMTickets
Fix SendCrossRealmPacket Needs to Send ObjectGUID in the call to BuildChatPacket, We may need to Make Some Change to this to Allow the GUID for crossrealm to work but will see how it goes when compiled and make the changes if needed then
Core/MergeErrorFix: * Remove Test Code fro Dk Chapter5.cpp Comment it out for now as it was not used and still was been worked on Will rewrite this when the Dk Area work get started again * Fix Missing "," in WorldSession.cpp
Fix Typo
Add IS_PLAYER_GUID back to the core As Cross realm Send the GUID of Realm+CharGUID to make it Know if it a cross realm Switch and this atm will not work though the ObjectGuid System so will need to let the old system handle this for now
Fix Override Error
Merge branch 'master' of ssh://git.neverendless-wow.com:5372/arthas/marinecore
Add Uint64 To be sent in the Whisper to Help having to Convert all of the chat server over to objectGUID
More merge errors, One of these day we may get a merge without having to change so much of out code to work with trinity stupid change, I get this is needed for WOD Expansion but not LK Blaaa...
Fix Duel Gamble System With new ObjectGuid Changes
More Merge errors
Fix NEVendor Whisper Player
Fix Player Whisper Merge Error
More Merge Error Fixers
Add GetLogNameForGuid back to the core
Missed Change in merge fix
Fix Warning in log Output
Some More OBJECTGUID Merge Error Fixers
For now add back some Object Defines Remove by Trinity ObjectGUID Will need to test the Website command scripts and change them to use the new system But lest just get it Working again so the merge can go live for now
Fix Auth Server to use the new way Trinity is Reading and sending the packet data Fixers NE Authenticator Checks/Data
Fix Merge Error In ActionHouseMGR
DB/Creature: BroadcastTextID for npc_textBy 41782992, closes #13286
DB/Misc: Cursed Cauldron / Cursed ScarabsThanks to @VincentMichael for the data on the missing trap objects
Removing the cauldron bubbles and smoke gos as these are meant to be summoned by spell used by one of the trap objects
Closes #11372
DB/Creature: Fix 1 startup error
DB/Misc: Valgarde ScriptsMove Anchorite Yazmina's waypoints from waypoint_data to waypoints and script her so she tends to the injured defenders and says texts as should.
Repeating event for Guard Captain Zorek
DB/Creature: Fix 1 startup error
DB/Creature: Fix 2 creatures faction Closes #13280
DB/Creature: BroadcastTextID for npc_textBy 41782992, closes #13279
DB/Creature: BroadcastTextID for creature_textBy 41782992, closes #13278
Update worldserver.conf.diststupid mistake....
Misc: Update some conf values/texts
DB/Misc: Couple more scripts* Repeating eent between Harbinger Vurenn, General Arlos and Counselor Talbot in Valiance Keep
* Script, text and conditions for Crusader of Virtue
Core/Instances: Add assert to track down a crashInstance reset times are supposed to be initialized on server startup and then only updated when they expire.
Refers to #11904
DB/Creature: correct spawn of 5 creatures
DB/Creature: BroadcastTextID for npc_textBy 41782992, closes #13275
DB/Brewfest: Added missing brewfest spawn in shatttath
Core/Misc: Added support for calculate zoneId/areaId for creature / gameoject table at loading (Slow server startup ca.3-4 sec.)
DB/Creature: K3 Perimeter TurretBy cr4st, closes #13158
DB/Creature: Linda Ann Kastinglow & Arcanist AlecBy Killyana. closes #12524
DB/Gossips: Assigned some gossips to their BroadcastTextIdBy 41782992, closes https://github.com/TrinityCore/TrinityCore/issues/13239
Core: Remove Whitespaces
Revert "Core/SAI: Added new error for is using other script as sai"This reverts commit d08862a7928707258f8741d7cb368b4622abc08e.
Core/SAI: Added new error for is using other script as sai
Core/SAI: Fix typo
DB/SAI: fix more startup errorsUpdates https://github.com/TrinityCore/TrinityCore/issues/13256
Scripts/Misc: fixed GameObjects chests in CoS and HoRFixes https://github.com/TrinityCore/TrinityCore/issues/13246
Core/SAI: Added new error log is not using SmartAI / SmartGameObjectAI in db
DB/SAI: fixed some startup errorsUpdates https://github.com/TrinityCore/TrinityCore/issues/13256
Core/Worldserver: Fix worldserver stuck on "Halting process" on shutdownPartially revert 4fe45b8c63d3c4118a0a69c6ed44573c53eba54c to fix worldserver stuck on "Halting process" on shutdown.
Fixes #13201
Fix Compile
Core/SAI: CleanUp in 98257b94728223ff027c3696b630462288c85255 / 2838a622647a1e12ec483b59440c7d0414dc14fa
Fix Pointer Sizes and Add some more debug Messages
See if this help the crashing issues on the who list
Fix Compile
Core/Sai: Added SMART_ACTION_TALK error log also for -guid creature
Core: Fix crash
Core/Brewfest: Fix typo in b74ef3f3ca277e7ce1bca7563fb0e9affbaf1a5a (thx to Gooyeth)
Core/Sai: Added new error log for action SMART_ACTION_TALK
Core/SmartScript: Fix warnings
Core/AHBot: Fix reference_loot_template being excluded from ahbot items Fixes #13265
Core/Sai: Added better version for 4060fb1b592ef50ab0c5bd450ddc94a1461e900e
Core/Sai: Added missing changes in 4060fb1b592ef50ab0c5bd450ddc94a1461e900e
Core/Sai: Added ugly code for new sai error log :(
Fixed ==25829== Thread #1: pthread_cond_{signal,broadcast}: dubious: associated lock is not held by any thread==25829== at 0x4C2A1D5: pthread_cond_broadcast_WRK (hg_intercepts.c:891)
==25829== by 0x654A758: std::condition_variable::notify_all() (in /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.17)
==25829== by 0x132305A: ProducerConsumerQueue<SQLOperation*>::Cancel() (ProducerConsumerQueue.h:100)
==25829== by 0x13229A7: DatabaseWorkerPool<WorldDatabaseConnection>::~Data baseWorkerPool() (DatabaseWorkerPool.h:70)
==25829== by 0x6C6CB21: __run_exit_handlers (exit.c:78)
==25829== by 0x6C6CB74: exit (exit.c:100)
==25829== by 0x6C54EF3: (below main) (libc-start.c:276)
DB/Quests: Fix half sleep fail in 6a471755231eb6481c7ce2091b58755b10373acc
Core/Spells: Added hack for "Bark for the Barleybrews!" quest credit (for alliance-side) (meh, blizzard :/)
Core/AH: Don't send expired auctions to clientsFixes #12964
Core/Spells: Added hack for "There and Back Again" quest credit (for alliance-side) (meh, blizzard :/)
Core/Brewfest: Added texts for quest "Bark for the Thunderbrews!" / "Bark for the Barleybrews!"
DB/Brewfest: Convert some brewfest for alliance: - Fix Quest "Bark for the Barleybrews!" (for Alliance-side) - Fix Quest "Bark for the Thunderbrews!" (for Alliance-side)
DB/Brewfest: Convert some brewfest for alliance: - Fix Quest "There and Back Again" (for Alliance-side) - Fix Quest "Now This is Ram Racing... Almost." (for Alliance-side)
Revert "Core/AuctionHouse: Delete expired auctions at startup."This reverts commit a92038feaf440abe797ee4b0344612b6176e43a8 which caused items of expired auctions not being mailed back to the owner and leaving those items in item_instance table.
Please refer to the forum for steps to verify the integrity of your database and remove old unneeded rows in item_instance table.
Fixes #12699
Core/LootMgr: Fix GCC warning
Core/LootMgr: Fix wrong bit fields padding
Core/SAI: Addet new error log for SMART_ACTION_CAST kill credit invalid target
DB/Misc: The Green Hills of Stranglethorn (3.3.5)Script replacement of misplaced chapters if player is rewarded for quest which rewards chapter but does not have item and has not turned in quest 338.
Core/Scripts: Fix invalid memory writeFix invalid memory write caused by calling "delete this;" in a base class constructor.
Core/Scripts: fixed memory leak caused by unassigned scripts in db
DB/Gossips: Added some more assignation to their proper BroadcastTextID
DB/Quest: Fix more locales on 3.3.5a
DB/Gossips: Added a missing one from 8983fbba531ac732ca48b9b78d85b2858eee67fd
DB/Gossips: Localized talents gossips by assigning them to their BroadcastTextID* Closes #12546
Core/AH: Fix Auction House items not deleted from databaseFix some cases where Auction House items were not deleted from item_instance table of character database, for example if the owner didn't exist anymore or if the owner was the AHBot.
Updates #12699
Updates #13232
Core/GameObjects: Fixed uninitialized elevator period value
WorldServer/Misc: Log possible errors on shutdownLog possible error on shutdown happening when trying to cancel any I/O sync operation in CliThread, refers to #13201
Buildsystem/MSVC: Removed /SAFESEH linker option from x86 debug builds as it doesn't make sense in debug builds and interferes with Edit and ContinueCloses #13233
Rename 2014_09_28_00_world_conversion.sql to 2014_09_28_00_world.sql
DB/Misc: Fix startup errors
DB/BroadcastText: Assigned BroadcastTextIDs to some texts
SQL: Fix sql import on unix
DB/Loot: Update SQL
Core/LootMgr: Update lootMgr to normalize loot_template tables
DB/SAI: Re-add SAI for Sprinkle that was accidentally deleted at d672e78a5b7a98f4b58936a0bd1c948028005dc0
Fixed GCC build
Core/Spells: Fix typo
SQL: meh, save button
DB/Gameobject: Fix wrong "Brewfest Banner" position in durotar
Misc/Brewfest: Fix Quest "11407 - Bark for Drohn''s Distillery!" / "11408 -Bark for T''chali''s Voodoo Brewery!"
Core/Misc: Refactor scripts to fix static analysis warningsLast issue to be fixed, fixes #12960
DB/Brewfest: Fix quest start for "Bark for T'chali's Voodoo Brewery!" / "Bark for Drohn's Distillery!" To/Do: Fix quest kill credit
Core/Spells: Always add threat for spells from spell_threat table, not only if target was hit. Unsuccessful cast results in 0 threat added instead of the full amount and creating threat list entry for caster. This fixes various exploits with taunt spells bugging out scripts due to taunt immunity/passive state (creatures would immediately evade resetting script state if no entries were present on threat list - entry with no threat is not the same as no entry)Closes #11883
DB/Quest: Fix LimitTime for Quest "Bark for Drohn's Distillery!" / "Bark for T'chali's Voodoo Brewery!" / "Bark for the Barleybrews!" / "Bark for the Thunderbrews!"
Scripts: Fixed compiler warning
Core/Debugging: Extended ASSERT macro to allow passing additional formatted string
Scripts/ManaTombs: Nexus-Prince Shaffar rewritten to BossAI/EventMap
DB/Creature: Delete incorrectly spawned Felhunter
Scripts/UtigardePinnacle: Prevent Ymiron from triggering a phase transition at death...caused by the health percent multiplers used to check transitions
DB/Quest: Tirion's GambitScript for chosen zealots is not perfect as this should surround player/tirion in a circle but cant think of anyway other than every chosen zealot having its own wp and sai.
Closes #10474
Scripts/Misc: Make InstanceScript::Initialize() obsoleteMove all InstanceScript initialization code from Initialize() to the constructor.
InstanceScript::Initialize() is now obsolete, please don't use it anymore. The only reason it's still in the sources is for backward compatibility.
Core/Misc: Refactor scripts to fix static analysis warningsEighth batch of fixes targeting 80 issues reported by Coverity
Scripts/Icecrown Citadel* Fixed Deathbringer Saurfang faction
* Fixed Coldflame faction
DB/Brewfest: Fix "Ram Master Ray" gossip
Scripting/Isle of Queldanas: Moved Converted Sentry to SAI. Closes #13121
Core/Achievements: Fixed wrong packet generation in AchievementMgr::SendCriteriaUpdate
Misc/Events: - Fix Quest "There and Back Again" (only Horde-side) - Fix Quest "Now This is Ram Racing... Almost." (only Horde-side) - Fix more spell mechanics for racing ram To/Do: Fix gossips and some optimize
DB/Quest: Free Your MindProper script for http://www.wowhead.com/quest=12893
Previous script gave credit on these npcs been killed which was wrong behavior
Core/Spells: Added missing stuff in 44bcfb86f5da0a5a374fc5b07431836b3c0f51c7
Core/Spells: Fix Ram Racing mechanic To/Do: Fix Quests and your lazy ass :/
DB/Creature: General LightsbaneScript General Lightsbane for quest If He Cannot be turned
DB/Misc: Error fixes Closes #13182
DB/Quest: Learning to Communicate* Conditions for The King's Empty Conch
* Scalders Abilities
* On Reward Text
DB/Quest: Birds of a Feather Fix this quest so it works as on retail
* Delete permament spawns of Female Kaliri Hatchling,
* Breaking a egg will now spawn either a Female Kaliri Hatchling or Male Kaliri Hatchling
* Female Kaliri Hatchling will despawn when captured and is now required for quest item to be used.
Core/Spell - Fix Remove Aura "The Eye of Acherus" Fixed remove aura "The Eye of Acherus" http://www.wowhead.com/spell=51852 after use "Recall Eye of Acherus" http://www.wowhead.com/spell=52694 .
Earlier, after using the player remained under the aura.
Scripts/Examples: Remove some more code related to example scripts
Core/Players/DK: Implement Rune Grace Period mechanic Closes #11736
Fixes #6122
Scripts/Examples: Remove outdated example scripts Remove outdated misleading example scripts not following anymore current TC codestyle and standards. Please refer to the wiki or forum for up to date examples and documentation.
Core/Misc: Refactor scripts to fix static analysis warnings Seventh batch of fixes targeting 100 issues reported by Coverity
DB/Creature Model: Fix a few models
Core:/SmartScript: Added log for item has credit spell blabla
SQLs: Rename updates/world sql files to the new format
Scripts/Shadowmoon Valley: Fix static analysis issues added in cd48ee01c0b1465c5b07427bb6fe9baa57f053b9Fix static analysis issues added in cd48ee01c0b1465c5b07427bb6fe9baa57f053b9 about uninitialized values and pointers possibly point to free'd memory being dereferenced.
In memory of all the developers who got banned from IRC in the process of fixing these issues.
SQL: Sync world_database after tdb 335.56 release
DB/Misc: Remove more additem hacks Use proper spells for creating items instead of sai action 56, this leaves only NR items using this action to add items as data missing for spells.
Core/ObjectMgr: corrected error labels
Scripting/Shadowmoon Valley: Added scripting for Infernal Attackers.
DB/Misc: Remove some hacks for additem* Replace sai to add some items with sai action 56 with correct spells to create items
* Add option and sai to replace Blood Elf Disguise for What Illidan Wants, Illidan Gets...
TDB 335.56 - 2014/09/21
SQL: Only 3.3.5a
DB/Creature: Delete 2 duplicate spawns
DB/Spells: Added missing EffectItemType stuff in spell_dbc table
DB/Spells: - Added EffectItemType columns to spell_dbc table - Fix "Create Bundle of Bloodthistle"
DB/Misc: Fix gossip condition which was never met Fix condition for gossip option 'Lend me a Windrider. I'm going to Spinebreaker Post!' on Wing Commander Brack for when player has got quest http://www.wowhead.com/quest=10242/spinebreaker-post.
The existing condition quest taken (9) was never met as this quest is complete in players log as soon as taken, ie just turn in no other objectives, and even when player had quest in log gossip would never be displayed,
DB/Misc: Respawn Invis Infernal Caster, Wildhammer Defenders, Shadowmoon Scouts, and removed Infernals.
Core/Misc: Update helgrind suppressions
Core/Misc: Avoid Helgrind reporting libstdc++ false positive race conditions
DB/Misc: Add missing creature spawns to Invasion Point, Shadowmoon Valley with pathing
Core/Misc: Refactor scripts to fix static analysis warnings Sixth batch of fixes targeting 100 issues reported by Coverity
DB/Gameobject: Properly spawn Deathforged Infernals in Shadowmoon Valley
DB/Creature: Some Shadowmoon missing spawns
Core/Spells: fixed Intervade Closes #13171
Core/Achievements: Fixed realm first kill achievement restrictions - now only the first group will be able to complete it Closes #2957
Update and rename 2014_09_20_0_world_creature.sql to 2014_09_20_00_world_creature.sql
DB/Creature: Stormpeak Wyrm proper respawntime
Core/Guilds: Fixed guild rank delete framexml event params
Scripts/Auchindoun: Darkweaver Syth- Despawn minions on death/reset
- Misc clean up
DB/Misc: Add pathing for Fjorn.
DB/Pathing: Pathing for existing Son of Corok. Some spawns missing.
Revert "Core: Fix build for msvc14"This reverts commit bd522a3853951cf8ea4b0b9e2f225a8bdc38da04.
Meh -.-
Core: Fix build for msvc14
DB/Pathing: Pathing for Creteus
DB/Misc: Redo some fixups for Dun Neffelem
DB/Misc: Misc fixes
DB/Misc: Cosmetic fixups for Dun Neffelem
Kill new compile warnings
Fixed sql fail
Core/Battlefield/WG: fixed warnings Ref #13169
Closes #12714
Core/ObjectMgr: check creature.orientation and gameobject.orientation range in loading Closes #13156
DB/Misc: Fix Seething Revenant Entry: 29504 spawns and add two missing paths.
Core/Mechanics: Fix prevent fleeing + fear Closes #9754
Players should never have been affected by SPELL_AURA_PREVENTS_FLEEING in the first place.
Curse of Recklessness will no longer prevent Fear effects, only prevent NPCs from fleeing (e.g. at low health).
Judgement of Justice will no longer prevent Fear effects, but will only prevent NPCs from fleeing (e.g. at low health).
Source: http://www.wowpedia.org/Patch_3.0.2
DB/Misc: Proper spawning and pathing of Stormpeak Wyrm
Revert "SQL: Update dev/world_database.sql"This reverts commit 09f9f3b6b12545e603cca4ef9c50b5415dca9d9a.
I forgot that world_database.sql should only get updated in TDB releases.
SQL: Update dev/world_database.sql
Core/Commands: Fix displaying in .baninfo character command.
DB/Misc: Medical Supplies / Sunhawk Reclaimer* Spawn Missing Medical Supplies http://www.wowhead.com/object=181898/medical-supplies
* Script Sunhawk Reclaimer
Core/Grids: Replace some magic numbers with constants(P.S.: That's why! @cs_misc.cpp)
Core/MapScripts: Use proper enum value for boss whisper in SCRIPT_COMMAND_TALK
Core/MapScripts: Use proper source unit in SCRIPT_COMMAND_TALK Closes #13161
DB/Misc: Various Fixes* Noggenfogger Elixir - Fix by @Rushor Closes #13041
* Sprinkle's Secret Ingredient - Fix by @Rushor Closes #13040
* Xavian Satyrs - Fix by @Rushor Closes #12965
* Icepaw Bear / Tails up - Closes #13030
Scripting/Tanaris: added a few enums
Oops.
Core/Misc: Multiple static analysis issues fixed (small optimizations and clear code)
Fixed build
DB/Misc: Some misc fixes for Northrend. Mostly fix flight speed of some npcs.
Core/Misc: multiple changes * fixed build * apply tc codestyle to ObjectGuid class * fixed warning
DB/Gossip: Proenitus Closes #13165
DB/Misc: More textsHowling Fjord again,also fixes the error from https://github.com/TrinityCore/Trini...9b39aec606c0ff
Core/AreaTriggers: enable areatrigger teleports in battleground Closes #11999
Core/Texts: added TextRange parameter to creature_textRanges:
0 - Normal (Default)
1 - Area
2 - Zone
3 - Map
4 - World
Ref #13116
DB/Creature: Remove disable combat movement from some SAIBy Malcrom
Shared/Logging: Use standard format specifier for size_tUse standard format specified PRIuPTR for printing/logging size_t type that can be either uint32_t or uint64_t depending on platform/build configuration
Core/Trade: Fixed enchanting soulbound items in trade Closes #12850
DB: Fix Quest I'm Not Dead Yet! (Not giving quest credit on End of waypoint Reached)
SQL: Fix sql import
Core/Misc: changed trinity string id to unsigned and removed obsolete code
DB/Misc: Queen AngerbodaFixes script for the Slumbering King.
Closes #10247
Scripts/Gundrak: cleanup InstanceScript * converted Gal'Darah and Moorabi to BossAI * add and correct some texts * fixed altar activation spell visual
Core/Scripts: implemented a guid map in InstanceScript, this way you can easier store guids and access its objects
Core/Spells: consider spell speed in SPELL_EFFECT_CHARGEMisc: removed some duplicate guid words in logs
Core/NetworkIO: Fixed queued packets not being properly sent causing players to be stuck during loading Closes #13120
DB/Quest: Matis the CruelScript this quest,
* One line is not proper text and thus no broadcast text id, the proper text is same line but with $n instead of npc name but on tc this gets filled by player name which for this text is not the right behaviour
* Know Matis gets up again after been captured, same happens on retail did not mean to replicate that bug but managed too.
Core/Grammar: corrected grammar of some strings
Core: Fix warnings
Core/SAI: Remove SMART_ACTION_STORE_VARIABLE_DECIMALIt's not used.
Core/Spells: Fix some -Wconversion warningsAttempt to fix #13152 by properly casting between data types during damage calculations.
Scripts/Quest: Script spell for quest "Fumping"Updates
Core/Misc: Removed explicit qualifier from ObjectGuid uint64 conversion operator
Core/Logging: Fixed incorrect usage of guid in logs
Core/Scripts: Fixed incorrect guid usage in logs
Core/Scripts: Fixed incorrect guid usage in logs
DB/Misc: DB Stuff for some quests.DB Changes for Fumping and A Really Big Worm
Neither of these quests will work until they get cpp support (spell scripts), @Nyeriah is on this believe, she already has spellscript for first now just 2nd is taking a while longer.
SQL: Fix typo at https://github.com/TrinityCore/Trini...008367c708bbbd
DB/Achievement: Set proper map difficulty for achievement "Oh Novos!"Closes https://github.com/TrinityCore/TrinityCore/issues/13150
Fix typo
Core/Scripts: Fixed PCH build
Core/Scripts: Fixed build zone_* scripts
DB/Misc: Respawn some npcs I did not mean to delete closes #13143
Core/Scripts: Fixed build of misc scripts, only zone_* and instance_* remain
Core/Scripts: Fixed build of boss_* scripts
DB/Misc; SpawnsDelete permament spawns of Frigid Ghoul and Frigid and get the npcs which attack these to cast the spells to summon them as they do in sniff.
Addition to https://github.com/TrinityCore/Trini...a5a560f8d698eI could have sworn I already added broadcast texts to original sql but seems where missing,
DB/Gameobject: Revert flags for Ulduar TeleporterBy digz6666, closes #13126
DB/Quest: The Fate of BloodbaneOk, pushing this as is there are some cosmetic issues which need cpp support but since asked several times if someone could fix spell and still not done,
The issue is cosmetic one where the omnious clouds spawn too close to ground,
Core/Scripts: Changed GetGUID/SetGUID script hooks to operate on ObjectGuid classFixed compile for boss scripts starting with letters B, C and D
Scripts/ToCR: Set Anub'arak's respawn delay* This needs to be done manually since he's a summon.
Closes https://github.com/TrinityCore/TrinityCore/issues/10587
Scripts* Introduced GetGuidData/SetGuidData to store guids in instance scripts (GetData64/SetData64 are still there)
* CONDITION_INSTANCE_INFO: Changed existing DATA64 condition to GUID_DATA to preserve current use of this instance info type (most/all assume the data is a guid) and moved DATA64 to a different value - no db changes needed
* Fixed compile in boss scripts starting with letter A
Core: Remove whitespace
DB/Vehicle: Update vehicle stuff for toc5
Scripts/Commands: Fix ".npc info" immune mask outputFix ".npc info" showing wrong immune mask list
Fixes #12358
DB/Misc: Update spawn for toc5
Scripts/Misc: Some code style fixes for old code
Core/Misc: Fixed build without pch
Scripts/OnyxiaLair:- Potential null pointer crash fix
- Reset react state properly on wipes during air phase
Scripting/Stand spell: Remove UNIT_FIELD_FLAGS change from spell script.
Scripts/Commands: Fixed build with -DSCRIPTS=0
Core/Misc: Fix issues reported by static analysis
Core/Entities: Use ObjectGuid class in game project
Scripting/Spell Stand: Move this spell to spells generic.
SQL: Fix sql import
DB/Misc: Missing spawns/phasingPhasing and missing spawns required for The Reckoning and Tirion's Gambit,
Note this does not fix these quests it only deals with spawns, phasing, gossip and gossip conditions.
Rename SQL
GMT: Add checks to see if Spell from the list are passive/Talent and Active
GMT: let return false if spellinfo is null
GMT: Let send the Spell rank of the player as well in the ShowSpells Script
Rename 2014_09_13_05_335world_misc.sql to 2014_09_13_05world_misc_335.sql
DB/Waypoints: Correct text of Artificer DaeloFixes #13130
Ref 27479cf571cf65c9e1657e9c4659
DB/Misc Cryo-Engineer Sha'heen (3.3.5)Fix Ethereal Transporter Control Panel in the mana-tombs to summon Cryo-Engineer Sha'heen http://www.wowhead.com/npc=19671
This npc is no longer summonable in game quest he gives was dropped in 4.3.
DB/Misc: Misc Fixes* Fix credit for researching gearmasters manual again as I somehow managed to omit this when I updated the event script to spawn him in proper position
* Spawn Greatfather Aldrimus http://www.wowhead.com/npc=19698, only problem is this npc is meant to be invisible until player until player has completed quest chain starting with I see dead dreanei, in sniff have no auras on this npc, only thing in bytes1 is 0x10008
* Spawn Skyguard Prisoner http://www.wowhead.com/npc=23383, believe there should be more possibly pooled have sniff of 1 only
* Drop Ragnaros Submerge Visual from Serfex the Reavers script, in sniff serfex did not cast this spell at all and actually had script to cast 2 submerge visuals but would always still be above ground,
Core/Quests: Don't display a message if the player doesn't meet the requirements for the next (automatic) quest in a chain.
SQL: Fix sql import
Scripts/Misc: Fix issues reported by static analysis
Scripts/CoS: Salarmm rewritten to BossAI/EventMap
Core/Chat: cleanup MonsterText methods
Script/CoS: Fix quest credit for mal ganis
Scripts/UtigardePinnacle: Use a generic spell to calculate the damage for Dark Slash insteadThanks to @Vincent_Michael for the heads up
Scripts/UtgardePinnacle: King Ymiron- Updated to EventMaps
- Replaced manual summons with proper spells
- Fixed glitch where boss would resume fight/run back to his main target before the ancestor summon roleplay was over (it might still need few adjustments i.e fire on boat is currently missing)
- Implemented damage calculation for spell Dark Slash (http://www.wowhead.com/spell=48292) as previously the spell would do no damage and it's BasePoints is 0
Core/Units: Take into account HoverHeight in IsWithinMeleeRange Fixes #12059
Closes #13104
Core/BG: use new GetUniqueBracketID() method to store statisticsCloses #13122
SQL: Fix travis build
DB/Misc: Fix visual appearance for some quest flight pathsFix appearance of player when taking flight for As the Crow Flies and Spiritual Insight
Link the spells which give transform (Stormcrow Shape for As the Crow Flies and Spiritual Insight for Spiritual Insight
Script to remove this at end of path, the zangarmarsh one lasts about 5 seconds longer than flight path, but the dragonblight one has 1 min left at end so needed to remove that,
Also dont know if anyone can think of a way of how to this but during as the crow flies the player is meant to receive a few whispers from ysiel during the flight path,
If you search spell_dbc for as the crow flies you will find there are a number of auras with name as the crow flies whisper aura with different effect msic values and different durations ranging from 3 to 467 I have a feeling these are meant to trigger the whispers when the auras expire think the values in effectvaluemisc2 maybe event ids.
SQL: Update /dev/world_database.sqlForgotten change of 27479cf571cf65c9e1657e9c465974449173dc3f
Core/Scripts: Nuke db_script_string table and make SCRIPT_COMMAND_TALK with broadcast_text insteadOriginal code by @Ascathor with modifications
Closes #13092
Core/Entities: Use new PackedGuid class
Core/Misc: Refactor scripts to fix static analysis warnings Fifth batch of fixes targeting 100 issues reported by Coverity
Core/Entities: Added ObjectGuid class from MaNGOS
DB/Quest: The Demoniac ScryerCloses # 2610
Script for http://www.wowhead.com/quest=10838/the-demoniac-scryer
Core/WorldSocket: Refactored client packet header check
Core/Misc: Added const modifier to MessageBuffer::Write parameter
DB/Gameobject: Allow to target 2 gameobjectsCloses #13093, closes #13094
Core: Fix warning
Core/NetworkIO: Set non blocking mode on sockets properly
Core/Skills: Fix rogue's lock picking Fixes #12677
Closes #13111
Core/Quests: Only prompt the player to take the next quest in a chain if he meets the conditions for that quest.
Scripts/CoS: implemented Infinite Corruptor, improvements in instance script and Meathook converted to BossAIGuardian of Time should have some text, but I have not found anything in sniff. Also the whole event needs to be rewritten and improved.
DB/Misc: Couple more fixes closes #13112
closes #13115
Core/Group: Update enum GroupType
Fix Compile
Fix mistake in last commit and possible crash from last commit
See if this solve the Turkey marker not giving Achievement Friend or Fowl credit
DB/Misc: Random fixes/error fixes
DB: The Worst Mage in Dalaran - A Children's Book Added missing Page text
DB/Item: Goramosh's Strange Device Drop chance Fixed
Core/Misc: Kill few more warnings.
Core/Misc: Get rid of some warnings.
Core: Fix typo in cec2cc806b418997f387bf1324454b7b76b9f0fa
a correction
Remove a Gossip Script which is already in DBRemove script for Khadgar all of the gossip menus and options are already in db and this is only a gossip script, will deal with db stuff in next commit
SQL: Fix typo.Fix typo in 587d87d2ccc888b0a881be4bfaab150422edaec8.
DB/Misc: Some additions to https://github.com/TrinityCore/Trini...0b09bebffeSome additions to https://github.com/TrinityCore/Trini...14ad0b09bebffe
* Add a missing npc_text where gossip menu had already existed in db with this text and core script sent this text as gossip but text was not in db
* Correct option id for a option.
Scripts/Misc: some small changes after recent commits
Convert Mount Vendor script to DBMove CPP script npc_mount_vendor to db
* Sniffed gossip menu for Veron Amberstill as we did not have this
* There is more than one text per gossip for these, readded all gossip menus we have to include the ones that where not in db already
* Conditions for vendor option and texts to only sell to elegible to players and show correct texts
We do not have text for Dreanei or dwarf have not checked gnome one since that one had already been moved to db since npc had sai
closes #13088
Core/Unit: Fix some movement issues when multiple controls are applied
Scripts/AV: Drekthar updated to EventMaps
SQL: Fix up my failure at 2014_09_11_00_world_conditions.sql
Scripts/Gundrak: Eck the Ferocious updated to EventMap/BossAI- Moved his spawn handling to instance script
Remove BOM from 2014_09_11_00_world_conditions.sql
DB/Conditions: Fix up conditions for Yogg-Saron's portal spells after latest changes to the instance data
Core/DB: Fix crash on shutdownFix race condition crash on shutdown, closing MySQL connections with queries still being executed
SQL: Fix wrong sql count order
Core/Misc: Fixed build with intel compiler
Core/Authserver: Added missing auth socket managerCloses #13085
DB/Misc: Cenarion Thicket* Add strange aura to spell_area for Cenarion Thicket (someone had tried getting the druids to cast this on themselves in sai whoever did obviously did not read this AttributesEx3: 0x00000100 (SPELL_ATTR3_ONLY_TARGET_PLAYERS)
* However even when aura is active it still would not hit druids only the Broken Corpses, found that the druids should not even have this aura (proper auras are permament feign death + blue radiation), also in sniff unit_flags2 is 2049 (we had 2048) and dynamic flags 0 (we had 40)
* Also removing stun from unit flags, this makes no difference in game as npc gets those flags from feign death
GMT: Add ShowSpell Script * Fix Profession Skill IDs * Add New Ticket Out Packet * Add profession Set Level Script * Add Profession Remove Script
Scripts/AV: Captain Galvangar updated to EventMaps
DB/Locales: Correct multiple quest names for the 3.3.5 patchRef #13075
DB/Locales: Correct multiple npc names for the 3.3.5 patchCloses #13075
Core/Loot: Fix a possible unintialized slot_type in LootMgrNoticed by @joschiwald
Core/Loot: Fix some issues with master lootThanks to @PortgasDAce for the initial patch
DB/Misc; Perry Gatneradd some additional lines,
Scripts/The Barrens: Make BIG WILL attackable in quest id 1719 (the affray)Closes #13072
Ref #4764
Core/Net: Fix GCC build
CI/Travis: Yet another attempt at reducing the number of killed builds
Core/Unit: Do not give client control back to player after fear if player is under player charm (UNIT_STATE_POSSESSED)
Remove CPP script for Jenny/Jezzix Geartwist
DB/SAI: Jenny (Load'er UP)Ok so found I needed to rescript this to as had not noticed there was already a script on Fezzix Geartwist for this quest, this sai has got same flaws as cpp version had, when npc gets attacked and evades looses crates aura (another example of the thing with auras getting removed at evade causing problems),
Remove seaforium depth chargeRemove cpp script for seaforium depth charge ((Bury those cockroaches)).
Build fix
DB/Misc: Borean Tundra Scripts* Quest turn in scripts for Souls of the Decursed, The Power of the Elements and Patching Up
* Proper script for Gearmaster Mechazod
* Rescripted Bury those Cockroaches to SAI, now includes the texts from the mines, also credit npc will no longer be knocked out of sink hole by first person to do quest after a restart rendering the quest non working to all other players who try after due to the npc present not been where its meant to be
* A couple of other one line fixes
Core/NetworkIO: Use reactor style sending on linux to reduce locking overhead
Core/Creature: Implement CREATURE_FLAG_EXTRA_IGNORE_PATHFINDING
Scripts/Onyxia Lair: Slight change so we don't call Reset() in the 'ctor
Scripts/Onyxia Lair: Some small improvements to GUID storage as it's only used locally
GMT: Add handler and Fix compile
fix compile error and Add Show Profession Script Part 1
GMT: Script the Add/Remove Item for CrossRealm
Scripts/Commands: Allow to set a custom duration to the Freeze command applied Aura- Allow to set a default duration for the Freeze Aura in worldserver.conf
- Handle the .freeze and .unfreeze command custom effects through the Freeze AuraScript
- Make players able to eventually unfreeze by themselves since the aura will expire without someone having to use .unfreeze
- Make .freeze command usable with the following syntax:
* .freeze (with a targeted player)
* .freeze duration_in_seconds (with a targeted player)
* .freeze playername duration (if duration is an invalid value it will be defaulted to the config one)
* .freeze playername (in this case, duration will be defaulted to the config value)
- Make .listfreeze command able to show the remaining freeze duration on all affected players
DB/Conditions: Argent Tournament Champions Daily questProper conditions for champions quests
Battle Before The Citadel, Taking Battle to the Enemy, Among the Champions and Threat from Above require that player is a champion ie has done quest a champion rises
Quests Eadric the Pure / The Scourgebane require that player is a champion
Threat from above has two requirements - That player is a champion and player has completed the black knights orders
The black knights Fall requires that player is a champion, quest chain breaks at the black knights orders if you are not champion
Core/Scripts: made BossAI::CheckInRoom virtual
Core/Misc: Named an unknown creature type flag
SQL: Renamed file to follow standards
get rid of the debug message not need anymore
Update debug message to see fi this is returning false
Would a static cast Work better ?
let re-enable the Authenticator
Add some debug for auth
Core/Misc: dropped obsolete GameObject::GetGameObject method
Core/Misc: Refactor scripts to fix static analysis warningsFourth batch of fixes targeting 100 issues reported by Coverity
Core/Misc: Meh some white lines, an addition to last sql's comment and a spotted typo
Scripts/AV: Balinda Stonehearth- Updated to EventMaps
- Removed manual spawning of Water Elemental by using proper spell
* The Water Elemental has a duration, it'll despawn once it's over. She'll resummon it during the encounter if it dies or disappears.
* Fixes it's level scalling with owner.
- Moved Water Elemental AI to database.
- Script update
** Patch 3.1.0 (14-Apr-2009): Now casts Ice Block.
DB/Misc: Kirin'Var VillageRescripts
http://www.wowhead.com/quest=10305 Abjurist Belmara
http://www.wowhead.com/quest=10182 Battle-Mage Dathric
http://www.wowhead.com/quest=10307 Cohlien Frostweaver
http://www.wowhead.com/quest=10306 Conjurer Luminrath
Rescripts all of these quests to work fully blizzlike including waypoints, all texts, and equipping items, previous scripts where using wrong npc for two of these quests or the entry they should change to after retrieving item
Also a few other visual fixes for this area, and fixing some run-time errors Aokromes asked to look at earlier.
DB/NPCs: Fix unit_class of some difficulty entries (DBErrors)
Scripts/ScarletMonastery: fix typo caused by copy-paste
Scripts/ScarletMonastery: Interrogator Vishas updated to BossAI and EventMap
DB/NPCs: Updates to unit_class, speed_run, speed_walk, BaseAttackTime and HoverHeight
DB/NPCs: Correct faction of multiple npcs, 3.3.x data
Misc: Add CONTRIBUTING.md
Update README.md
Scripts/Stratholme: Move Freed Soul AI to database and a small addition- They should follow players until they despawn
Ethereal Teleport Pad & Ethereum Transponder Zeta* Replacement for CPP script which was scripted not using the gossip menu / option which this go should have had but on activate instead, now will display proper gossip menu and option which spawns Image of Wind Trader Marid
* Fix Ethereum Transponder Zeta so it actually works and delete the permament spawn of Image of Commander Ameer
Remove CPP script for Ethereal Teleport PadRemove CPP script which was not using proper mechanism for activating (ie gossip)
Core: Remove again whitespace (meh :/)
Core/Misc: Clear some outdated SD2 notes from recently modified scripts
Scripts/Scholomance: Kormok- Updated to EventMaps
- Replaced some hacks to summon adds with proper spells, but there might be still missing stuff
Core/InstanceScript: refactored load and save methods
Core/DBLayer: Fixed GetUInt32,GetInt64 and GetUInt64 on windows when value stored in db was greater than 2147483647
Scripts/Commands: Fix issues reported by static analysisFix possible buffer overflow in ".server shutdown" and NULL-dereference/Triggered Debug Assert.
Scripts/Scholomance:- Updated Ras Frostwhisper to EventMaps
- Updated Vectus to EventMaps
DB/Quests: The Summoning Chamber/A Curse Upon Both Your Clans Ok first thing I have to say is even though a Curse Upon Both your clans now works with this script, the spawns are not done in correct way due to missing spells which are not in spell_dbc either but are in sniff, Nayd had no luck searching for them either.
Anyway script for
http://www.wowhead.com/quest=10602 The Summoning Chamber
http://www.wowhead.com/quest=10585 The Summoning Chamber
http://www.wowhead.com/quest=10544 A Curse Upon Both Your Clans
Also spawn missing deathforge summoners from the summoning area,
Closes #4837
Closes #6776
Fix typo
Add Player Activity Logging for the use on the PTR/Dev realm when we need to log testers in-game hours for rewards
DB/NPCs: Remove equipment from Huldar Closes #13032
DB/NPCs: Add equipment to a couple of creatures
Misc: Update worldserver.conf.dist to TC standards
DB/Locales: Correct a few gameobject names Closes #13049
Should bring back Custom Item BG Switchers Will need testing to make sure this is correct way of doing it
DB/NPCs: Set BaseAttackTime and RangeAttack to 2000 where these values were 0
This should bring back arena Cheater System
DB/NPCs: Remove duplicated lines from previous file (creature_model_info). Oops.
DB/NPCs: Multiple updates to creature_model_info
DB/GOs: Multiple updates to gameobject_template
Well that may have not been a great Idea let see if this stop the core lockup
lets clean up the code , ChatServer is now Working again (Cross links will need some testing to make sure all that works
SQL: Rename SQL after recent PR merge
Scripts/Commands: Move instance command strings to database
DB/Creature: Fix hover for "Maiden of Drak'Mar" in 7a04d5ee8276a81156af9fb7ac13521441cb3f36
DB/NPCs: Remove dynamicflags that should not be in the DBTapped and lootable flags
DB/Misc: Fel Crystal Prism* Spawn missing spawns of Fel Crystal Prism http://www.wowhead.com/object=185927
* Script these to be usable to summon demons (needed in order to properly complete a Felwhip for Gahk!) at a cost of 35 Apexis shards
* Scripts for the 4 demons
* Adjustments to the egg scripts I made earlier have had to add the spell to take reagents to script (even though is meant to be triggered from other spell) but was failing ie not taking reagents.
and here we go again
Another merge error
Core/Misc: Refactor scripts to fix static analysis warningsThird batch of fixes targeting 100 issues reported by Coverity
DB/SAI: Also fix the other of the four dragonsAlready fixed Obsidia from sniff
I dont have sniffs of the other 3 but can still make these so the summon and payment occurs in properway.
As with Obsidia all dragons are spawned by event script which is triggered from spell, egg despawns to prevent multiple spawns (even though this would be rather stupid as costs 35 shards to call each dragon.
Allow players to track both herbs and minerals at the same timeNote: The following are client limitations and cannot be coded for:
* The minimap tracking icon will display whichever skill is activated second
* The minimap tracking list will only show a check mark next to the last skill activated (sometimes this
bugs out and doesn't switch the check mark. It has no effect on the actual tracking though).
* The minimap dots are yellow for both resources
Change ACE_OS::localtime_r -> localtime_r
Fix ACE -> Boost Conversions Some of this may need reworking but lets see how this works out before we start re-scripting everything
Scripts/Auchindoun: Updates Pandemonius to EventMaps/BossAI
DB/SAI: To Rule the SkiesProper script for Obsidia / Obsidia's Egg for quest http://www.wowhead.com/quest=11078/to-rule-the-skies
Now reagents are taken and Obsidia spawned using correct spells
Ie
http://www.wowhead.com/spell=41035 (Four Dragons: Force Cast - Obsidia) which is cast on player as invoker cast when gossip option selected which triggers